Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke etelemetry when constructing a DandiAPIClient; honor DANDI_NO_ET #728

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Invoke etelemetry when constructing a DandiAPIClient; honor DANDI_NO_ET #728

merged 2 commits into from
Jul 22, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 22, 2021

Closes #726.

@jwodder jwodder added the minor Increment the minor version when merged label Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #728 (eef72bd) into master (cf0c118) will increase coverage by 0.12%.
The diff coverage is 62.50%.

❗ Current head eef72bd differs from pull request most recent head 8959978. Consider uploading reports for the commit 8959978 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   84.02%   84.14%   +0.12%     
==========================================
  Files          59       59              
  Lines        5664     5703      +39     
==========================================
+ Hits         4759     4799      +40     
+ Misses        905      904       -1
Flag Coverage Δ
unittests 84.14% <62.50%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/command.py 50.63% <0.00%> (+6.18%) ⬆️
dandi/utils.py 80.36% <66.66%> (-0.53%) ⬇️
dandi/dandiapi.py 90.93% <100.00%> (-0.01%) ⬇️
dandi/exceptions.py 100.00% <0.00%> (ø)
dandi/tests/test_dandiapi.py 100.00% <0.00%> (ø)
dandi/upload.py 84.02% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0c118...8959978. Read the comment docs.

yarikoptic
yarikoptic reviewed Jul 22, 2021
View reviewed changes
dandi/cli/command.py Outdated
"Failed to check for a more recent version available with etelemetry: %s",
exc,
)
check_dandi_version()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think indentation is wrong and it falls under if pdb:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, import makes it obvious... shouldn't be just in pdb mode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@yarikoptic
Copy link
Member

Thank you @jwodder -- let's proceed and see where it brings us

@yarikoptic yarikoptic merged commit 184cc30 into master Jul 22, 2021
@yarikoptic yarikoptic deleted the gh-726 branch July 22, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move etelemetry logic to become in effect also when used as a Python library
2 participants
@jwodder @yarikoptic